client-go icon indicating copy to clipboard operation
client-go copied to clipboard

[WIP] Introduce Codec

Open AmoebaProtozoa opened this issue 3 years ago • 1 comments

This PR aims unify CodecPDClient and CodecPDClientV2 by introducing a Codec interface.

AmoebaProtozoa avatar Jul 27 '22 16:07 AmoebaProtozoa

There is a bug that might block this pull request: https://github.com/tikv/client-go/blob/bb026bdad8f34604cc01fdafbaf4063729583a44/txnkv/txnsnapshot/scan.go#L217. We should use to check if we need to proceed the scan:

			if len(reqEndKey) == 0 || (len(loc.EndKey) > 0 && bytes.Compare(loc.EndKey, reqEndKey) < 0) {
				reqEndKey = loc.EndKey
			}

iosmanthus avatar Aug 03 '22 09:08 iosmanthus