lixa icon indicating copy to clipboard operation
lixa copied to clipboard

Lz profile

Open LWilkinson-LzLabs opened this issue 4 years ago • 7 comments

Here is our first addition to the lixa_tx API, to allow the application to specify the profile prior to tx_open with a lixa_tx_set_profile(const char *profile). This setting will override the LIXA_PROFILE environment value. The override is cleared on tx_close. The test changes (case0038.c, tx_cobol.at, xta_8_0.at) were required to allow "make check" to work in our environment.

LWilkinson-LzLabs avatar Feb 09 '21 10:02 LWilkinson-LzLabs

Thank you for the addition: I will carefully review it in the next few days.

tiian avatar Feb 09 '21 21:02 tiian

Please pay attention I have committed 7e239d8e9fe0b0727e7df9aabc6510e83af0e8be in the master branch to fix a CodeQL error due to the migration of the builder to Ubuntu 20.04. I suggest to merge your branch with the master one to incorporate the fix.

tiian avatar Feb 20 '21 20:02 tiian

Commit 0cd0212a6cbe9c92a05f38a802828d5cc0400f13 added documentation for XA functions call order with TX and XTA API.

tiian avatar Feb 23 '21 21:02 tiian

Just a ping: The docs were updated to contain some information - but what about the actual content of this PR? Also: Could the testsuite adjustments be split / directly checked in (from a glance the COBOL one looks like it should skip on "no" instead of "yes" btw)?

GitMensch avatar Dec 22 '21 16:12 GitMensch

Just a ping: The docs were updated to contain some information - but what about the actual content of this PR? Also: Could the testsuite adjustments be split / directly checked in (from a glance the COBOL one looks like it should skip on "no" instead of "yes" btw)?

I have not merged the pull request because who proposed the pull request didn't agree to implement the new feature in a 100% LIXA compliant architecture, see the exchange on February 23rd, 24th. Fine for me some user creates its own derivative version, but I don't merge code that carries potential concurrency issues.

tiian avatar Dec 24 '21 15:12 tiian

I see. What do you think about the testsuite adjustments?

GitMensch avatar Dec 24 '21 19:12 GitMensch

I see. What do you think about the testsuite adjustments?

I don't remember exactly, but the testsuite adjustments were related to the pull request only and the main repo should be ok. If not, please open an issue on it.

tiian avatar Dec 25 '21 09:12 tiian