InfluxData.Net icon indicating copy to clipboard operation
InfluxData.Net copied to clipboard

-Point2 class added to support nano and micro seconds insert/get

Open ummarbhutta opened this issue 8 years ago • 2 comments

-Nano and microsecond support added

ummarbhutta avatar Nov 10 '17 11:11 ummarbhutta

Thanks for this. I'll use some bits of the code you made, but I'll have to refactor it. I want to avoid introducing an additional class Point2 which is essentially a duplicate just to support NS and MS, it would bring in confusion. The original Point class should support MS and NS.

tihomir-kit avatar Mar 20 '18 09:03 tihomir-kit

Hello @pootzko Thanks for your feedback. Couple of points why I implemented it in this way.

  1. In Point Timestamp is of type DateTime, and DateTime can't provide nano seconds resolution.
  2. I extend the Point class to add an additional timestamp field of type long, In my opinion adding this field to same Point class can add to confusion.
  3. I understand that playing with DateTime is very convenient in C#, but for nano seconds the user has to provide long value of nano seconds
  4. Change impact was lower.

Anyways I would be happy to provide any help if required.

ummarbhutta avatar Apr 02 '18 12:04 ummarbhutta