receiving notifications while the app/chat is open

[nanopone]

trafficstars

Describe the bug when reading a chat and receiving a message in it, siskin sends a push notification anyway, which is annoying and not expected since other messaging apps do not do this. it seems like an oversight

To Reproduce Steps to reproduce the behavior:

1. open a chat
2. receive a message from inside of that chat

Expected behavior i expect siskin to not send any push notifications either when the chat is open or when the app is open at all

Details (please complete the following information):

• Siskin Version: 7.3.3
• iOS version: 16.3.1
• iPhone model: iphone 13 mini

[hantu85]

Siskin does not generate nor send push notifications - it displays them.

You've also reported #213 which in fact is causing this issue as well (in my opinion). Most likely your server doesn't care if your XMPP client is connected and sends push notifications even if your client is connected. This in my opinion is an issue with the implementation of XEP-0357: Push Notifications on the sever side as in the introduction of this XEP it is stated:

The purpose of push notifications is to inform users of new messages or other pertinent information even when they have no XMPP clients online.

In this case, you do have a connected client and you receive notification anyway.