siskin-im icon indicating copy to clipboard operation
siskin-im copied to clipboard

Registering account don't work

Open pravi opened this issue 2 years ago • 20 comments

Describe the bug Registering account does not work.

To Reproduce Steps to reproduce the behavior:

  1. install app
  2. Open app
  3. Try to register
  4. It does not work, save settings has no effect and adding contact says account not online.

Expected behavior We should be able to register accounts

Screenshots If applicable, add screenshots to help explain your problem.

Details (please complete the following information):

  • Siskin Version: latest
  • Branch:
  • Xcode version: [e.g. 11]
  • iOS version [e.g. 11.0]
  • iPhone model [e.g. iPhone 11] Tried on 3 different iphones, none worked.

Additional context Add any other context about the problem here.

pravi avatar Nov 23 '21 11:11 pravi

Which server? The Tigase ones or others?

licaon-kter avatar Nov 23 '21 12:11 licaon-kter

There are no details here. Please add missing details:

  • iOS versions
  • used XMPP servers
  • which SiskinIM was causing the issue? (from AppStore or from TestFlight)

I can say that I've tested it with a few servers and it worked without any issue.

hantu85 avatar Nov 23 '21 12:11 hantu85

iPhone 11 Pro and iPhone 12. sure.im and tigase.im was tried.

pravi avatar Nov 23 '21 12:11 pravi

Installed from app store.

pravi avatar Nov 23 '21 12:11 pravi

It could be a non intuitive flow as well.

pravi avatar Nov 23 '21 12:11 pravi

Have you read the account registration instructions presented to you? You need to confirm your email by tapping on the link sent to your email address. Then you need to enable accounts in the SiskinIM settings to make them work.

hantu85 avatar Nov 23 '21 12:11 hantu85

3 of my friends could not sign up, I tried myself as well.

pravi avatar Nov 23 '21 12:11 pravi

But this was not clear at all from the ui that email confirmation is necessary.

pravi avatar Nov 23 '21 12:11 pravi

Probably there should be a standard way to represent pending confirmation status from server and display it on the client side.

pravi avatar Nov 23 '21 14:11 pravi

can confirm this is an issue, was able to register in monal no issue, for example to conversations.im but it did not work here, unending loading spinner . iphone 7 ios 15.4

theotheroracle avatar Nov 21 '22 18:11 theotheroracle

Unfortunately, there is no way to indicate that the account requires confirmation (in the XMPP specification it is not defined). We will work on improving UX in this case.

hantu85 avatar Nov 21 '22 19:11 hantu85

@hantu85 I can see conversations on android asks for a captcha confirmation for conversations.im accounts. May be we can do a similar thing to ask for the confirmation code sent via email or possibly adding sms otp confirmation as another option - as many people seem to prefer sms over email?

pravi avatar Dec 01 '22 13:12 pravi

I think https://xmpp.org/extensions/xep-0158.html is flexible enough to authenticate via email confirmation.

pravi avatar Dec 01 '22 13:12 pravi

The confirmation to create an account (captcha support) is already implemented (and even used by the server during account creation). The issue here is to confirm the email account - the server sends a link and the user needs to open it but the user is not aware of that. We plan to fix that but other things had higher priority.

hantu85 avatar Dec 01 '22 15:12 hantu85

Can't the email confirmation also be presented as a second challenge so user will know they have to respond? The clicking link can be replaced by entering a confirmation code received in email. But if you think you already found a better way, that should be fine.

pravi avatar Dec 01 '22 15:12 pravi

I think about using SASL2 for that. It is implemented in a preview version and hopefully, we will be able to use it soon (waiting for publication of updated version of the XEP).

hantu85 avatar Dec 01 '22 15:12 hantu85

What do you think about XEP-0389 in this context?

pravi avatar Dec 28 '22 20:12 pravi

@hantu85 I think sasl2 update is published now https://xmpp.org/extensions/xep-0388.html

pravi avatar Mar 12 '23 09:03 pravi

There are:

  • XEP-0388: Extensible SASL Profile: https://xmpp.org/extensions/xep-0388.html
  • XEP-0440: SASL Channel-Binding Type Capability: https://xmpp.org/extensions/xep-0440.html
  • XEP-0474: SASL SCRAM Downgrade Protection: https://xmpp.org/extensions/xep-0474.html
  • XEP-0480: SASL Upgrade Tasks: https://xmpp.org/extensions/xep-0480.html

Neustradamus avatar Dec 22 '23 01:12 Neustradamus

Hi, thank you for updating the issue.

Just so you know. We have migrated onto Tygrys platform. All our projects are available at https://tigase.dev/ address and the Tigase SiskinIM project is here: https://tigase.dev/tigase/_clients/siskin-im

All the existing issues have been migrated as well. This particular issue can be found here: https://tigase.dev/tigase/_clients/siskin-im/~issues/522

arthef avatar Dec 22 '23 04:12 arthef