topicsolved icon indicating copy to clipboard operation
topicsolved copied to clipboard

Incompatibility with phpBB 3.3.0

Open notsoencrypted opened this issue 5 years ago • 11 comments

Just updated to the new version of PHPBB, and unfortunately, this extension broke with the update. It's a super useful one for my RPG group, so I'd love to see an update.

image

notsoencrypted avatar Feb 17 '20 23:02 notsoencrypted

I am getting the same issue and would love to see this updated to 3.3.0.

Hippie459MN avatar Feb 21 '20 01:02 Hippie459MN

The fix for that error message is pretty trivial. You just need to add quotes around any values that start with @ in that listed file. That gets rid of the error. The extension seems to work for me under phpBB3 with these changes. Not sure if other compatibility fixes are needed.

Changes to ext/tierra/topicsolved/config/services.yml:

5c5
<             - @tierra.topicsolved.topicsolved
---
>             - "@tierra.topicsolved.topicsolved"
9,11c9,11
<             - @tierra.topicsolved.topicsolved
<             - @controller.helper
<             - @template
---
>             - "@tierra.topicsolved.topicsolved"
>             - "@controller.helper"
>             - "@template"
17,19c17,19
<             - @tierra.topicsolved.topicsolved
<             - @template
<             - @request
---
>             - "@tierra.topicsolved.topicsolved"
>             - "@template"
>             - "@request"
25,30c25,30
<             - @dbal.conn
<             - @user
<             - @auth
<             - @dispatcher
<             - %core.root_path%
<             - %core.php_ext%
---
>             - "@dbal.conn"
>             - "@user"
>             - "@auth"
>             - "@dispatcher"
>             - "%core.root_path%"
>             - "%core.php_ext%"

aberkvam avatar Mar 01 '20 02:03 aberkvam

Hi @tierra,

could you update your extension? Or do you want I submit a new PR for that?

Regards.

Galixte avatar Apr 02 '20 14:04 Galixte

Bonjour dommage , c'est une extension des plus pratique dans mon forum. j'ai fait la modification , vider le cache , mais il n'y a pas de changement. je suis en phpbb 3.3.0. Y a t-il une autre astuce que je ne vois pas. Merci pour votre soutien.

philmusic39 avatar Jun 15 '20 08:06 philmusic39

Bonjour dommage , c'est une extension des plus pratique dans mon forum. j'ai fait la modification , vider le cache , mais il n'y a pas de changement. je suis en phpbb 3.3.0. Y a t-il une autre astuce que je ne vois pas. Merci pour votre soutien.

Take a look, here: https://www.phpbb.com/customise/db/extension/topic_solved/support/topic/215181?p=754206#p754206. ;)

Galixte avatar Jun 18 '20 16:06 Galixte

Merci Galixe . j'ai re-installé , modifier et tout fonctionne. Je suis ravi , vous faites un excellent travail. bonne continuation et protéger vous bien .

philmusic39 avatar Jun 18 '20 17:06 philmusic39

Take care too. ;)

Galixte avatar Jun 18 '20 23:06 Galixte

"@dbal.conn"

This is incorrect you don't want double quotes, you want single quotes.

rmcgirr83 avatar Jun 20 '20 13:06 rmcgirr83

"@dbal.conn"

This is incorrect you don't want double quotes, you want single quotes.

Thanks, PR submitted: https://github.com/tierra/topicsolved/pull/74.

Galixte avatar Jun 21 '20 13:06 Galixte

Is this repo abandoned? Why is PR#1 not yet accepted and the ext updated to work with current stable phpbb?

boczpeter avatar Nov 28 '20 15:11 boczpeter

This Issue shouldn't have been solved with this commit https://github.com/tierra/topicsolved/commit/531c116746e05b4636b9cba1a4da78ec68ef57b8 by @Galixte ?

gremirarunico avatar Apr 05 '22 11:04 gremirarunico