Étienne Beaulé

Results 61 comments of Étienne Beaulé

Yes, it's ready for review (2.4)

It would be possible to add some tests to things such as cost calculations (although it would take quite a bit of setup). Don't think it would be necessary for...

> Venue allocation methods have been added which returns optimal venue assignments based on the given constraints. In addition, new methods allow for venue rotation so that teams are not...

Negative numbers can happen when there is unexpected feedback, and so it would be good to check those cases. Such extraneous feedback should be automatically unconfirmed however: #473.

> Though the automatic unconfirmation only happens on save, right? That's correct, so existing feedback would not be unconfirmed when changing the setting, and both changing the settings mid-way and...

``` WARNING Compiled with 18 warnings 11 h 58 min 11 s Module Warning (from ./node_modules/eslint-loader/index.js): /Users/etienne/Git/tabbycat-cloned/tabbycat/adjallocation/templates/DebateOrPanelAdjudicators.vue 46:19 error Expected to return a value in "averageScore" computed property vue/return-in-computed-property 51:25...

Yes, I'd say this would make most of Django somewhat obsolete, like with all the work placed into templates/forms, and would then have to be migrated over to the frontend....

It's been many years; we've since switched to gunicorn! Should we compare both, to decide whether we'd want to switch back? We don't seem to have a problem with our...

Great! Don't hesitate to ask if you need anything!

Fixed in 7fa47eb7e2ff996b01171c05e1aad64d1719033d.