Tienifr
Tienifr
@srikarparsi Hey I'm working on it, I expected the video to complete first but now I think I should open the PR first to get the initial review. PR wil...
It'll be up it 1 hour.
@srikarparsi I got a bit confused at how `HAS_SEEN_TRACK_TRAINING` is set. We would show this training interstitial only once, after that we wouldn't show it again. So what's the point...
@srikarparsi Also in offline mode, we definitely couldn't fetch to show the video, do you want to show a placeholder animation just like [onboarding welcome video page](https://staging.new.expensify.com/onboarding/welcome-video), or would we...
PR ready for review https://github.com/Expensify/App/pull/40675.
@srikarparsi Does the above asset need to be uploaded to CloudFront? If yes, how can I do it?
# Proposal The Emoji is italicized because it is contained in the `` tag (same as when we make a text italic). We can observe the behavior on both Chrome...
working well after the fix: https://user-images.githubusercontent.com/113963320/216310065-25e96b0c-aa25-4f56-bd73-79cd9d89c878.mov
Thanks @s77rt for your suggestion! # Updated proposal Adding to [the original proposal](https://github.com/Expensify/App/issues/14676#issuecomment-1413526293), Here's the my updated diff for the regex so that it matches all rather than just one....
@s77rt Regarding the `fontWeight: 'normal'`, I don't feel strongly about since it doesn't seem that the bold fontWeight affects how the emoji looks.