Tienifr

Results 171 comments of Tienifr

[$250] Clicking on "New Messages" jumps to newest messages, skipping over any messages marked unread report by @chauchausoup

# Proposal ## Problem - Currently, the logic scroll to unread message is using `scrollToBottom ` function https://github.com/Expensify/App/blob/7b21103bb56eb0cf3fc1561715613d2a16c3255f/src/pages/home/report/ReportActionsView.js#L285 - function `ReportScrollManager.scrollToIndex` isn't work correctly in web because it has different...

[$250] Clicking on "New Messages" jumps to newest messages, skipping over any messages marked unread report by @chauchausoup

@eVoloshchak Thanks for your review 1. The `scrollToIndex` is used in a lot of places, so I think it is better way to access clientHeight and paddingTop 2. Because we're...

[$250] Clicking on "New Messages" jumps to newest messages, skipping over any messages marked unread report by @chauchausoup

@eVoloshchak sorry, I don't catch on your mean 1. I'm updating the logic for `scrollToIndex` not `scrollToBottom` 2. We're implementing `invertedWheelEvent` in our project and FlatList in `react-native-web` works well,...

[$250] Clicking on "New Messages" jumps to newest messages, skipping over any messages marked unread report by @chauchausoup

Thanks @srikarparsi , I applied to the job and the PR will be ready by October 21

Default rooms are not grayed out when creating a new workspace while offline

# Proposal ## Problem In https://github.com/Expensify/App/blob/0724337138a4d80f6603074cc9af5c186cb524ec/src/libs/ReportUtils.js#L817-L852 when build the optimistic data for default chat report (admin, announce) we don't set `pendingFields` for them so In https://github.com/Expensify/App/blob/0724337138a4d80f6603074cc9af5c186cb524ec/src/components/LHNOptionsList/OptionRowLHN.js#L102 and https://github.com/Expensify/App/blob/0724337138a4d80f6603074cc9af5c186cb524ec/src/components/OptionRow.js#L136 the pendingAction...

Default rooms are not grayed out when creating a new workspace while offline

@eVoloshchak we're using `buildOptimisticChatReport` in 4 places: announceChatData, adminsChatData, expenseChatData, policyReport. As we can see the result above when pendingFields of announceChatData, adminsChatData, expenseChatData are updated to null when we...

Default rooms are not grayed out when creating a new workspace while offline

Hi @eVoloshchak We are using buildOptimisticChatReport in 8 places In /Expensify/App/src/libs/ReportUtils.js 1. line 901: announceChatData (for creating workspace ) 2. line 917: adminsChatData (for creating workspace ) 3. line 929:...

[$1000] Web -Chat -Changes made offline will not be saved after connecting to an internet connation, error message displayed

# Proposal ## Problem I see this is BE bug. Even when online (don't disable network connection), this issue still display. As the below video, when I change `notificationPreferences`, it...

BUG: Tapping "CHAT WITH YOUR SETUP SPECIALIST" takes to the mweb with a blank page. reported by @thesahindia

# Proposal ## Solution because `💬 CHAT WITH YOUR SETUP SPECIALIST` has the format: https://www.expensify.com/newdotreport?reportID=> if internalExpensifyPath start with 'newdotreport?reportID=', I'll get the `reportID` value and navigate to appropriate chat....

[$250] Bug: Old dot link without ‘www.’ prefix ( expensify.com/inbox) does not auto signin to old dot reported by @sobitneupane

# Proposal ## Problem In https://github.com/Expensify/App/blob/d6baba0be2da93beee72d8f21a6ee83e297fdd1a/src/components/HTMLEngineProvider/HTMLRenderers/AnchorRenderer.js#L28-L48 we check `attrHref.startsWith(CONFIG.EXPENSIFY.EXPENSIFY_URL)` to detect it's expensify url or not, but `EXPENSIFY_URL` = `https://www.expensify.com/` ## Solution In https://github.com/Expensify/App/blob/d6baba0be2da93beee72d8f21a6ee83e297fdd1a/src/components/HTMLEngineProvider/HTMLRenderers/AnchorRenderer.js We'll remove `www.` in `attrHref` and...