feasts icon indicating copy to clipboard operation
feasts copied to clipboard

Published 20 hours ago • verified publisher icon tidyverts

Reconsider class for ACF lag column

Open mitchelloharawild opened this issue 4 years ago • 4 comments

From #70

Use a difftime to represent lags instead of the cf_lag class. Store the interval elsewhere for plot breaks.

mitchelloharawild avatar Dec 02 '19 09:12 mitchelloharawild

@earowang I don't think difftime can be used because it doesn't support irregular units such as months. Does this sound reasonable?

mitchelloharawild avatar Jan 07 '20 03:01 mitchelloharawild

Hi, I was about to make an issue in respect. I lack some functionality for either type conversion/coercion or cf_lag handling in general. The current class is a bit cumbersome in the downsteam analysis and e.g. wanting to use other plotting libraries than ggplot2. What are your thoughts on this?

AEBilgrau avatar Feb 11 '20 09:02 AEBilgrau

I have ideas for a new temporal vctrs object for handling temporal aggregation (https://github.com/tidyverts/fabletools/issues/59). This new temporal class will also support origin-less time offsets which ACF will use. It will have also have scales methods so it should work with ggplot2.

mitchelloharawild avatar Feb 11 '20 09:02 mitchelloharawild

Wait for https://github.com/mitchelloharawild/moment to provide origin-less time structures

mitchelloharawild avatar Jan 11 '21 12:01 mitchelloharawild