tidytemplate icon indicating copy to clipboard operation
tidytemplate copied to clipboard

ASCII rectangles on pkgdown are off

Open krlmlr opened this issue 1 year ago • 6 comments

README: https://github.com/tidyverse/duckplyr/?tab=readme-ov-file#usage-for-individual-data-frames

Website: https://duckplyr.tidyverse.org/#usage-for-individual-data-frames

Scroll down a bit.

krlmlr avatar Aug 20 '24 16:08 krlmlr

In Firefox I see:

image

krlmlr avatar Aug 20 '24 23:08 krlmlr

@maelle: Any idea? This is Firefox only, Safari is better. No idea about other browsers.

krlmlr avatar Aug 21 '24 12:08 krlmlr

To make things worse, it looks good for me on Firefox on Ubuntu

image

maelle avatar Aug 21 '24 12:08 maelle

My investigation notes at https://github.com/pola-rs/polars/pull/18187#issuecomment-2302077398

hadley avatar Aug 21 '24 14:08 hadley

so why not use https://github.com/rstudio/keras3/blob/6ff11d22946960439fee830338ffd29422a5b294/pkgdown/_pkgdown.yml#L26-L32?

maelle avatar Oct 07 '24 12:10 maelle

It's not the same style. I've worked around with plain dashes for now, I'd rather fix for good or keep it as is.

When I inspect the code chunk, I see "Font Awesome 6" being mentioned. Is this the same as "Source Code Pro"?

Would it help if we served a more complete version of "Source Code Pro", if https://github.com/google/fonts/issues/4235 turns out to be the issue?

image

krlmlr avatar Oct 07 '24 17:10 krlmlr