`.by` support in `fill()`/`complete()`/`expand()`

[markfairbanks]

To match the .by implementation in dplyr v1.1.0 functions.

• [x] fill() https://github.com/tidyverse/tidyr/pull/1572
• [ ] complete()
• [ ] expand()

[DavisVaughan]

Will have to wait for tidyr 1.4.0 (i.e. after dplyr 1.1.0 is released)

[hadley]

@DavisVaughan does it have to? We added it to the upcoming dbplyr release.

[DavisVaughan]

That seems different though because dbplyr controls the whole underlying implementation. Here we just pass through to a dplyr function like mutate() or summarise(), so without dplyr 1.1.0 the arguments wouldn't do anything.

I guess we could check to see if dplyr 1.1.0 is installed if .by is attempted to be used and error if there isn't a new enough version of dplyr, but that didn't feel worth it when I originally thought about this

[hadley]

Ok, makes sense.

[mattwarkentin]

Absolutely love the addition of the per-operation .by/by arguments in dplyr. Now that dplyr 1.1.0 is released, will these be added to the aforementioned tidyr functions. Seems like tidyr::nest() already got the makeover.

[DavisVaughan]

We will add them in the next tidyr release. It was easier with nest() because tidyr owns the implementation. With the others we call out to dplyr so we needed to wait on 1.1.0

[joeycouse]

+1 on adding .by to complete and expand

[DanChaltiel]

Hi @DavisVaughan Is a release planned in the near future? The PR has been merged for more than 1 year now, and it would be nice to be able to enjoy fill(.by), even if the other two are not done yet.