stringr icon indicating copy to clipboard operation
stringr copied to clipboard

Fix vectorised replacement failures

Open hadley opened this issue 1 year ago • 1 comments

  • [ ] https://github.com/hughjonesd/huxtable
  • [ ] https://github.com/stefano-meschiari/latex2exp
  • [ ] https://github.com/eco-hydro/phenofit
  • [ ] https://github.com/stevecondylios/priceR
  • [ ] https://github.com/byzheng/rtiddlywiki
  • [ ] https://github.com/mdlincoln/salty

hadley avatar Jul 16 '24 21:07 hadley

This might be a fun challenge if you're very familiar with the package development process — you need install the dev version of string, fork each package, use pak::pak() to load all dependencies, then run tests/R CMD check, and fix the revealed bugs in str_replace_all(). Previously the functions were passed a single function and now they're passed a character vector, so you'll need to figure out how to vectorise the existing code.

hadley avatar Jul 16 '24 21:07 hadley

  • [x] https://github.com/hughjonesd/huxtable/pull/357
  • [x] https://github.com/stefano-meschiari/latex2exp no longer depends on stringr
  • [ ] https://github.com/eco-hydro/phenofit cannot install (their cpp setup is broken) so I gave up :)
  • [x] https://github.com/stevecondylios/priceR/pull/62
  • [x] https://github.com/byzheng/rtiddlywiki/pull/3
  • [x] https://github.com/mdlincoln/salty/pull/7

SereDef avatar Sep 19 '25 19:09 SereDef

@SereDef this is super useful, thanks so much!

hadley avatar Sep 21 '25 12:09 hadley

More from the latest round of revdep checks:

  • [x] https://github.com/christopherkenny/bskyr — https://github.com/christopherkenny/bskyr/pull/46
  • [x] https://github.com/pepijn-devries/ECOTOXr — https://github.com/pepijn-devries/ECOTOXr/pull/74
  • [x] https://github.com/stefano-meschiari/latex2exp — https://github.com/stefano-meschiari/latex2exp/issues/67
  • [x] https://github.com/nmautoverse/NMsim — https://github.com/NMautoverse/NMsim/pull/38

hadley avatar Sep 23 '25 13:09 hadley

Now tracking all in #590

hadley avatar Sep 23 '25 20:09 hadley