purrr icon indicating copy to clipboard operation
purrr copied to clipboard

Update error handling docs

Open hadley opened this issue 1 year ago • 5 comments

Once https://github.com/r-lib/rlang/issues/1533 and https://github.com/r-lib/rlang/issues/1534 are in a released version of rlang.

hadley avatar Jan 04 '23 18:01 hadley

No sure where this would go in your task schedule, but this broke in tidymodels.
https://github.com/tidymodels/recipes/issues/1081

P.S. I am going to go back to having to a roll back of every package in tidyverse due to this bugs similar to this one.

lbui30 avatar Feb 06 '23 01:02 lbui30

@lbui30 as requested in that issue, I think you need to start by providing a reprex.

hadley avatar Feb 06 '23 16:02 hadley

With the help of @lbui30, we were able to locate the problem which happened with a modification of an example we had on tidymodels.org. Thus purrr wasn't at fault.

EmilHvitfeldt avatar Feb 17 '23 00:02 EmilHvitfeldt

Thanks @EmilHvitfeldt is correct. However, something about purr or the tidyverse does make the output of errors still bit confusing to figure out. So, I was recommended by a co-worker to bring this up here as a motivating example of the need to have clearer error handling messages.

Errors were so much easier when they referenced code line numbers and had a common sense order in them. If there is anyway to help the reader identify the lines of code better in the new error handling docs, then I think that would be a great contribution.

lbui30 avatar Feb 19 '23 04:02 lbui30

@lbui30 we have done our best to make the errors informative and actionable, so if you have a counter example, we'd really appreciate seeing a reprex that illustrates it.

hadley avatar Feb 19 '23 15:02 hadley