googledrive icon indicating copy to clipboard operation
googledrive copied to clipboard

Revisit `drive_id` printing in the context of `dribble` printing

Open jennybc opened this issue 2 years ago • 0 comments

When tibble went from 1.6.4 to 1.6.5, googledrive's snapshot tests started to fail.

In the name of pragmatism, I'm basically just going to accept those changes, to get back to green on CI.

But next time I work on drive_id, I should look into whether tibble now makes it easier to print drive_id the way I want: print in full if we aren't short on space, but truncate heavily otherwise.

The new short_formatted argument to new_pillar_shaft_simple() seems very relevant for drive_id: https://github.com/r-lib/pillar/pull/389/files

Here's where I abandoned a previous effort to get "adaptive truncation": https://github.com/tidyverse/googledrive/pull/364/commits/76e15728a8fc14f8a769c200c712563ae68a300d

jennybc avatar Jan 31 '22 16:01 jennybc