ggplot2 icon indicating copy to clipboard operation
ggplot2 copied to clipboard

Rename `justification` settings to `just` settings

Open teunbrand opened this issue 3 months ago • 3 comments

This PR aims to fix #6607.

I'll reiterate that this is just for consistency purposes. I know from previous revdepchecks that some packages save their themes to objects instead of regenerating them by calling theme(). Other packages have expect_silent() in their test, which is incompatible with lifecycle changes. Such packages are at risk of being negatively affected.

teunbrand avatar Sep 26 '25 09:09 teunbrand

If the code is building a <theme> object, no. If they're reading out a <theme> object, it might. I could be persuaded that this is a risky move that is not worth the intended benefit of consistency.

teunbrand avatar Dec 03 '25 14:12 teunbrand

Ah - I see now how you deal with the old spelling inside the code... I'm fine with putting this in the code base - if you want we can run a revdepcheck on it before merging?

thomasp85 avatar Dec 03 '25 19:12 thomasp85

Yeah I think a revdepcheck would be wise for this.

teunbrand avatar Dec 03 '25 19:12 teunbrand