ggplot2
ggplot2 copied to clipboard
tidyverse
Accreditation of Author in `stat_ellipse()` Documentation
Hello everyone,
I hope this finds you well.
I noticed that the authors mentioned in the stat_ellipse() function are the authors of the car package and not specifically not those who made the function it was inspired from (car::dataEllipse())
I have attached a screenshot of the documentation below.
The other two authors of the given function (besides for John Fox) are Georges Monette and Michael Friendly who were the ones together with Fox help develop the idea and the function.
Attached is the relevant documentation from the car package showing their contributions:
As a student of Georges I think it would be appropriate to give him as well as Dr. Friendly a mention in the stat_ellipse() documentation as they both together with Fox founded and elucidated the idea of data ellipses (besides for being developers for the dataEllipse() function).
The relevant paper on the concept of data ellipses written by Monette, Fox and Friendly is here
I understand that you may just want to attribute the package authors and not the relevant contributors but I thought it would be worthwhile trying to get them both mentioned in the documentation as well.
Looking forward to hearing back.
You're welcome to prepare a PR. One issue I see though is that probably nobody has access to the 1990 paper cited in the car package, so there's no way for us to verify that the reference actually makes sense. We're citing the materials that we have access to and have looked at.
While I can't say anything about the 1990 paper I do know of a more recent paper (circa 2013) which highlights the relevant insights buy Fox, Friendly and Monette here.
A brief search on google scholar seems to indicate that the 1990 is one of those things that is probably lost in the web or never made it there.
The Fox et al paper definitely looks appropriate to me. Feel free to prepare a PR that adds this reference.
Here's the original contribution: https://github.com/tidyverse/ggplot2/commit/008018cce9a5063efb2eaa9cb917850a3ee762ea.
We look forward to your PR.
