ggplot2 icon indicating copy to clipboard operation
ggplot2 copied to clipboard

Issue a message when fill aesthetic is used with GeomPoint and shape is not "filled"

Open netique opened this issue 4 years ago • 2 comments

I've spend an hour or so of ggplot2 debugging to find out that fill aesthetics is simply ignored when shape of the point is not 21:25, i.e., not "filled". grid::grid.point, which is used, documents this case quite well, but ggplot2 gives a hint only through the example that could be "hidden" from the user that struggles with, e.g., boxplot ouliers fill modification (as in my case).

I would hugely appreciate to get warning/message that inform the user he or she is demanding something that won't work as intended, like it is the case when I use scale_alpha_* with continuous variable.

netique avatar Mar 02 '21 14:03 netique

While I empathise with the problem, I don't think a check like this is suitable for scatterplots that have in the millions of points as such a check slows down plotting quite a bit. I've argued against input validation here but I think the documentation could be a bit more explicit.

teunbrand avatar Apr 26 '24 09:04 teunbrand

OK, makes sense to me.

netique avatar Apr 26 '24 11:04 netique