dplyr icon indicating copy to clipboard operation
dplyr copied to clipboard

Next round of database defunctions

Open hadley opened this issue 3 years ago • 3 comments

#4663

hadley avatar Jul 26 '22 12:07 hadley

This breaks:

  • bigrquery
  • childesr
  • ckanr
  • dm
  • etl
  • farr
  • funneljoin
  • geospark
  • RPresto

The fixes are generally straightforward (import dbplyr::sql() instead of dplyr::sql()) so I think it's probably worthwhile.

hadley avatar Jul 26 '22 18:07 hadley

Also I added the known revdep failures to https://github.com/tidyverse/dplyr/issues/6262

DavisVaughan avatar Aug 02 '22 15:08 DavisVaughan

Newly detected failures:

  • macleish (from etl)
  • moodleR
  • sejmRP
  • sergeant
  • sparklyr, sparklyr.flint
  • taxizedb
  • vegdata
  • wordbankr

This pushes it to the point where I think we should probably hold off on for now, and see what our appetite for handling revdep failures is closer to the release.

hadley avatar Aug 03 '22 20:08 hadley

At this point, I think we have enough revdep failures that we don't want to add more. Let's push this off for a future release.

hadley avatar Dec 04 '22 18:12 hadley