design

design copied to clipboard

Designing S3 generics for extensibility

1

As long as the generic contains `...`, `R CMD check` does not compare the method and generic args. See for sample package that verifies that. And R CMD check code...

hadley

hopefully not too premature.

maxheld83

lindbrook

Fix typos and formatting, some small style improvements, add link to `modelr::na.warn()` reference. See also #116 for more typo fixes.

salim-b

salim-b

Assignment outside of if

1

```R if (is.null(version_label)) { version_label

hadley

Early exits

2

If you have an if statement with a large `if` and small `else`: ```R if (cond) { # # # # # # # # } else { something() }...

hadley

Mutable state within a package

1

i.e. `the

hadley

Initiatialising a variable on package load

15

Summarizing a recent Slack discussion that seems worth preserving. The conversation was triggered by https://github.com/r-lib/gargle/issues/184, where someone following a pattern seen in several gargle-using packages was getting push back from...

jennybc

When to use warnings instead of errors

1

One place to use a warning is where you wish you had originally made an error, but changing the behaviour now would break a lot of code.

hadley