parsnip icon indicating copy to clipboard operation
parsnip copied to clipboard

reverse dependency check in actions

Open topepo opened this issue 1 year ago • 2 comments

Set up a cron job GH action to run revdepcheck::revdep_check() for parsnip

topepo avatar Jul 05 '24 15:07 topepo

I think this was the best possible misspelling of dependency😝

I'm not super enthusiastic about this one. I feel that:

  • Unexpected reverse dependency breakages haven't bit me too much in the past. If I unexpectedly break something, I can wait to submit for two weeks, and if I can't wait to submit for two weeks, I would have made a moment to run revdepchecks two weeks prior.
  • In tidymodels, we tend to maintain multiple Remotes depending on each other at once, which (at least) cloud_check() has trouble with.
  • False positives: I often find, when running revdepchecks, I have to debug one or two installation issues before getting results that I believe. (CRAN seems to struggle with false positives in automated revdepchecks, too.) I think we'd end up with a lot of noise and maintenance burden that would end up being more burdensome than our existing, manual workflow.
  • Speed: with the publicly available runners, we only have access to 4 cores. For some of our packages, this would be a very long-running Action, especially in juxtaposition to the massively parallel cloud_check().

simonpcouch avatar Jul 08 '24 15:07 simonpcouch

I think this was the best possible misspelling of dependency😝

Wow.

When we do a release, we are supposed to give revdep package maintainers 2-3 weeks to get on CRAN. That could complicate things if we are in a hurry and get caught by something unexpected.

topepo avatar Jul 15 '24 18:07 topepo