broom icon indicating copy to clipboard operation
broom copied to clipboard

Use testthat 3

Open olivroy opened this issue 1 year ago • 2 comments

I also silenced a couple of tests / output along the way.

olivroy avatar Dec 04 '23 17:12 olivroy

Thanks for triggering CI. As you see, there is still a lot of noise in the logs. I will try silencing most of it. It is mostly due to the fact that packages loaded in broom's tests are quite noisy on load. (when clicking on show testthat output)

olivroy avatar Dec 05 '23 22:12 olivroy

Noise in the logs is okay! What's more important is my ability to understand the change set comprehensively. As-is, there are still many changes that seem unrelated to the switch to testthat 3e—I'd welcome those other changes in separate PRs where their scope is more clearly defined, but will ask you to further pare back the changes here to only those needed to related to switching to 3e.

simonpcouch avatar Dec 07 '23 14:12 simonpcouch