Tommy Nguyen

Results 97 comments of Tommy Nguyen

> Going to look at this soon, I just got a react-native-macos port for `@invertase/react-native-apple-authentication` package and I am _not_ manually adding macos as an example platform 😅 You know...

> Okay everything seems to work locally for me except for `start:android`, seems to be an activity name resolution problem, but I haven't dug in to AndroidManifest or src/main/java to...

> My questions weren't really netinfo specific, so this was a big list of things that won't affect this PR actually :-), for instance I don't think tvos or catalyst...

@mikehardy, do know when you will have time to have a look at this? Just need to know whether you want me to rebase this PR or just leave it...

@afoxman, do we need to provide a better error message here? Or not enable `typescriptValidation` in this scenario?

Somewhat related: #256. I can imagine it would be useful to also pull in `@types/react-native` when you have dependency `react-native` for instance.

Just an FYI, we are currently using [TSDoc](https://tsdoc.org/) to generate the API tables for the `tools-*`'s `README` files: https://github.com/microsoft/rnx-kit/blob/99854bb31038b6069047ef8ac2777ba4dacd1dd3/scripts/src/commands/updateApiReadme.js#L8 It has its own quirks. For instance, you have to manually...

> Can iOS run Hermes byte-code? Is it interpreted or JIT-compiled into native code? Not sure. FYI, Apple does not allow JIT on iOS. It has to be interpreted.

Before we close this issue, we should also update the types: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/3625f7e63f834d0e37aa062127a903ca1ce8a3b8/types/metro-resolver/types.d.ts#L104-L109

Does this also happen when you run the rn-cli? ``` yarn react-native bundle --entry-file src/index.ts --platform android --bundle-output dist/main.android.bundle grep injectGlobalResponderHandler dist/main.android.bundle ``` Or are you saying this is a...