vscode-titanium icon indicating copy to clipboard operation
vscode-titanium copied to clipboard

Improve error message if no SDK version is selected

Open hbugdoll opened this issue 2 years ago • 4 comments

Describe the Bug

If no Titanium SDK version is selected, no clear error message is shown in VSCode.

Steps to reproduce the Bug

  1. Have several SDK versions installed and one selected.
  2. Delete the selected SDK version (and forget to run titanium sdk select to select another installed SDK version).
  3. Try to build a project for a simulator or a device.
  4. Neither simulators nor devices are listed in the Titanium extension tree. The less helpful error message "Cannot read properties of undefined (reasing 'simulators')" occurred after refreshing devices.
  5. Running titanium on the terminal shows the dilemma:
[ERROR] Invalid selected Titanium SDK ...
[ERROR] Run "titanium sdk select" to set the selected Titanium SDK

Expected Behavior

Show directly the error message "Invalid selected Titanium SDK ..." in VSCode.

Your Environment

Software Version
Titanium SDK 10.1.1.GA / 11.0.0.GA
VS Code 1.69.2
vscode-titanium 1.0.0

hbugdoll avatar Jul 20 '22 09:07 hbugdoll

Please update to the latest CLI with

npm i -g titanium

and try if the error comes up again.

caspahouzer avatar Jul 20 '22 09:07 caspahouzer

@caspahouzer Thanks for the hint. Updating Titanium CLI from older v5.4.1 to latest v6.1.1 has no effect on this issue.

hbugdoll avatar Jul 20 '22 10:07 hbugdoll

The PR at https://github.com/tidev/titanium-editor-commons/pull/752 sets up the changes for this issue. The plan is to introduce a new issues screen similar to the missing tooling one that already exists. It will prompt to fix any issues like this that block the extensions functionality

ewanharris avatar Aug 02 '22 18:08 ewanharris

@ewanharris That's great news. Thanks.

hbugdoll avatar Aug 02 '22 22:08 hbugdoll

This was implemented in #1028 and shipped in v1.1.0

ewanharris avatar May 10 '23 21:05 ewanharris