titanium-sdk icon indicating copy to clipboard operation
titanium-sdk copied to clipboard

chore(android): gradle 8

Open AbdullahFaqeir opened this issue 3 months ago • 2 comments

chore(android): let there be gradle 8 chore(android): fixed deprecations in kroll-apt project chore(android): made kroll-apt incremental to enhance build time

GitHub issue: https://github.com/tidev/titanium-sdk/issues/13579

This PR is dedicated to my mentor Nafe Abboushi.

AbdullahFaqeir avatar Mar 23 '24 19:03 AbdullahFaqeir

I have to do some testing but the first round was very good and I was able to build kitchensink an my app now :+1:

Review will follow once I have more time to test

m1ga avatar Mar 26 '24 18:03 m1ga

What sort of testing do we need to do to get this over the finish line?

:+1: @cb1kenobi I would love to split this up into smaller steps as this is a big PR: https://github.com/tidev/titanium-sdk/issues/13579#issuecomment-2021150043 I have made older PRs: first one only updates the gradle files to the newer syntax, 2nd one updates cmake and checkstyle (looks much but it's only linting). Then we only have the gradle 8 parts in here and can focus on that as it's a bigger change.

m1ga avatar May 01 '24 08:05 m1ga