titanium-sdk icon indicating copy to clipboard operation
titanium-sdk copied to clipboard

fix(android): use maxMemory as property

Open m1ga opened this issue 1 year ago • 0 comments

resolves https://github.com/tidev/titanium_mobile/issues/11068

Using camel-case for maxMemory CLI + tiapp.xml property.

Before tiapp.xml uses android.javac.maxmemory and CLI used android.javac.maxMemory

After both use android.javac.maxMemory

Test

  • add <property name="android.javac.maxmemory" type="string">1G</property> to your tiapp.xml
  • it will stop and showing an error that you should use maxMemory
  • use <property name="android.javac.maxMemory" type="string">1G</property> and it will build fine

Since many users won't use this at all I've used process.exit(1); and stopped the build. This way I don't have to support both values.

m1ga avatar Sep 14 '22 10:09 m1ga