titanium-sdk icon indicating copy to clipboard operation
titanium-sdk copied to clipboard

feat(ios): add tabsTransparent and tabsBackgroundView properties

Open AndreaVitale opened this issue 4 years ago • 2 comments

JIRA: https://jira.appcelerator.org/browse/AC-6533

In an app that I'm developing I need to create a custom shape for the TabGroup. So I need to add a custom view to use as background. There no way with the current TabGroup properties to set the it with transparent background. So I added both tabsBackgroundView and tabsTransparent properties in order to achieve a result like this:

Schermata 2020-06-11 alle 15 09 51

AndreaVitale avatar Jun 11 '20 13:06 AndreaVitale

Fails
:no_entry_sign:

:microscope: There are library changes, but no changes to the unit tests. That's OK as long as you're refactoring existing code, but will require an admin to merge this PR. Please see README.md#unit-tests for docs on unit testing.

Messages
:book:

:floppy_disk: Here's the generated SDK zipfile.

:book: :tada: Another contribution from our awesome community member, AndreaVitale! Thanks again for helping us make Titanium SDK better. :thumbsup:
:book: :fist: The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
:book:

:white_check_mark: All tests are passing Nice one! All 6688 tests are passing. (There are 703 skipped tests not included in that total)

Generated by :no_entry_sign: dangerJS against 9f8b363aaa0984c6f8ffc7f237fd3f181f4ea331

build avatar Jun 11 '20 13:06 build

@AndreaVitale I can see that the underlying implementation is different here, but what exactly are the differences between the new properties and tabsTranslucent and tabsBackgroundImage? It's not immediately/obviously clear to me when you'd use one set of properties versus the others. Do we have a simple code sample to compare?

sgtcoolguy avatar Jun 23 '20 15:06 sgtcoolguy