feat(ios, android): add new API's, fix existing API's
Open
hansemannn
opened this issue 7 years ago
•
4 comments
All changes are in parity with https://github.com/hansemannn/titanium-googlemaps.
Android:
- Add
poiclick event
- Add
containsCoordinate method
- Add
geometryContainsLocation method
- Add
geometryDistanceBetweenPoints method
- Support encoded polylines in
Polyline.points
- Fix
showAnnotations to handle multiple annotations at once
- Fix
padding property
- Fix crash in overlay click events
iOS:
- Refactor source (use TitaniumKit imports, remove Xcode 9 guards)
- Add
containsCoordinate method
- Fix
padding property
|
Fails |
| :no_entry_sign: |
version bump was Major in ios/manifest but None in package.json |
| :no_entry_sign: |
npm run lint failed, please check messages below for output.
|
|
Warnings |
| :warning: |
SDK version declared in Jenkinsfile (9.0.0.v20200207060625) does not match iOS' titanium.xcconfig value (9.0.2.GA) |
| :warning: |
:mag: Can't find junit reports at ./TESTS-*.xml, skipping generating JUnit Report.
|
|
Messages |
| :book: |
:bomb: Here's the output of npm run lint:
> @titanium-sdk/[email protected] lint
> npm run lint:android && npm run lint:ios && npm run lint:js && npm run lint:docs
> @titanium-sdk/[email protected] lint:android
> clang-format-lint android/src/**/*.java
Error: Formatting incorrect on "android/src/ti/map/MapModule.java", proposed changes: <?xml version='1.0'?>
<replacements xml:space='preserve' incomplete_format='false'>
<replacement offset='7134' length='1'> </replacement>
<replacement offset='7558' length='0'> </replacement>
<replacement offset='7681' length='0'> </replacement>
<replacement offset='7813' length='0'> </replacement>
<replacement offset='7904' length='1'> </replacement>
<replacement offset='8033' length='4'> </replacement>
<replacement offset='8395' length='1'> </replacement>
<replacement offset='8553' length='1'> </replacement>
<replacement offset='8761' length='1'> </replacement>
<replacement offset='8771' length='8'> </replacement>
</replacements>
Error: Formatting incorrect on "android/src/ti/map/PolygonProxy.java", proposed changes: <?xml version='1.0'?>
<replacements xml:space='preserve' incomplete_format='false'>
<replacement offset='4980' length='3'> </replacement>
<replacement offset='5040' length='2'> </replacement>
</replacements>
Error: Formatting incorrect on "android/src/ti/map/PolylineProxy.java", proposed changes: <?xml version='1.0'?>
<replacements xml:space='preserve' incomplete_format='false'>
<replacement offset='1135' length='0'> </replacement>
<replacement offset='1196' length='5'> </replacement>
<replacement offset='1288' length='12'> </replacement>
<replacement offset='1375' length='12'> </replacement>
<replacement offset='1457' length='12'> </replacement>
<replacement offset='3182' length='6'> </replacement>
<replacement offset='6898' length='3'> </replacement>
<replacement offset='6958' length='2'> </replacement>
<replacement offset='8928' length='6'> </replacement>
<replacement offset='9115' length='6'> </replacement>
</replacements>
Error: Formatting incorrect on "android/src/ti/map/TiUIMapView.java", proposed changes: <?xml version='1.0'?>
<replacements xml:space='preserve' incomplete_format='false'>
<replacement offset='2997' length='1'> </replacement>
<replacement offset='3050' length='16'> </replacement>
<replacement offset='7420' length='6'> </replacement>
<replacement offset='7930' length='6'> </replacement>
<replacement offset='8039' length='6'> </replacement>
<replacement offset='15521' length='3'> </replacement>
<replacement offset='24420' length='1'></replacement>
<replacement offset='24451' length='1'></replacement>
<replacement offset='24457' length='4'> </replacement>
<replacement offset='24525' length='1'> </replacement>
<replacement offset='25929' length='1'></replacement>
<replacement offset='25960' length='1'></replacement>
<replacement offset='28362' length='1'> </replacement>
<replacement offset='28385' length='5'> </replacement>
<replacement offset='28407' length='6'> </replacement>
<replacement offset='28518' length='1'> </replacement>
<replacement offset='28627' length='6'> </replacement>
<replacement offset='42386' length='1'> </replacement>
<replacement offset='42426' length='6'> </replacement>
<replacement offset='42686' length='6'> </replacement>
<replacement offset='42868' length='6'> </replacement>
</replacements>
Error: Formatting incorrect on "android/src/ti/map/ViewProxy.java", proposed changes: <?xml version='1.0'?>
<replacements xml:space='preserve' incomplete_format='false'>
<replacement offset='1877' length='1'> </replacement>
<replacement offset='1910' length='8'> </replacement>
<replacement offset='10200' length='0'> </replacement>
<replacement offset='10241' length='9'> </replacement>
<replacement offset='13003' length='3'> </replacement>
<replacement offset='13279' length='3'> </replacement>
<replacement offset='27139' length='4'> </replacement>
<replacement offset='27503' length='1'> </replacement>
<replacement offset='27638' length='1'> </replacement>
<replacement offset='27824' length='0'> </replacement>
<replacement offset='32148' length='4'> </replacement>
<replacement offset='32199' length='4'> </replacement>
<replacement offset='32265' length='1'> </replacement>
<replacement offset='32267' length='4'> </replacement>
<replacement offset='32298' length='4'> </replacement>
<replacement offset='32338' length='3'> </replacement>
<replacement offset='32362' length='0'> </replacement>
<replacement offset='32399' length='4'> </replacement>
<replacement offset='32404' length='4'> </replacement>
</replacements>
|
Generated by :no_entry_sign: dangerJS against 614927dc356f71bf18d5697e9b6daedd1cad511f
@janvennemann you can run npm run lint to make dangerJS happy :smile:
May 31
'23 18:05
m1ga
@m1ga Thx! Unfortunately, the linting does not seem to work:
> @titanium-sdk/[email protected] lint:android
> clang-format-lint android/src/**/*.java
TypeError: Cannot read properties of undefined (reading 'stdout')
@hansemannn sorry, it's npm run format to fix the linting. npm run lint is just to check it again
Jun 02
'23 17:06
m1ga
tidev
