community icon indicating copy to clipboard operation
community copied to clipboard

Create the giphy app

Open DigitallyBorn opened this issue 3 years ago • 6 comments

Allows users to display random gifs based on a configurable search query. giphy

DigitallyBorn avatar Aug 16 '22 21:08 DigitallyBorn

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

tidbyt-bot avatar Aug 16 '22 21:08 tidbyt-bot

I have read the CLA Document and I hereby sign the CLA

DigitallyBorn avatar Aug 16 '22 21:08 DigitallyBorn

Should mention there's some risk we'll have to do some changes for performance reasons if the app becomes popular. The graphics are randomly selected on each run, and we'll very rarely be able to cache the data. That has some impact on how many devices we can support running it. One possible workaround is to only display the (e.g.) first result in a search, or to cycle through them more slowly (perhaps something like (time.now().unix / 30) % image_count as an index).

matslina avatar Aug 18 '22 18:08 matslina

Wonderful app! I'm a bit worried about Giphy's rate-limits though. What are your thoughts on that?

Since it isn't published and I have nothing to show Giphy, I can't promote the API key to a production key and have the rate limits lifted. Once it's on the device I'll take pictures of the device and screenshots of the iPhone app showing the required attribution. Hopefully, it's enough to get the limit lifted. (You have to follow brand guidance and I did the best I could.)

If that fails, I'll remove my API key and provide an input field for users to supply their own. That's not a great UX, but I imagine the TIDBYT audience is pretty techy, so far. It'd be super annoying for people who want to add the app multiple times.

If that fails, you could always take what I've built, put the extra little changes needed to the iOS and Android apps to properly show branding, and kick it out as a non-community app.

life finds a way

DigitallyBorn avatar Aug 19 '22 00:08 DigitallyBorn

Should mention there's some risk we'll have to do some changes for performance reasons if the app becomes popular. The graphics are randomly selected on each run, and we'll very rarely be able to cache the data. That has some impact on how many devices we can support running it. One possible workaround is to only display the (e.g.) first result in a search, or to cycle through them more slowly (perhaps something like (time.now().unix / 30) % image_count as an index).

It's worth mentioning that it's not really really random. Each time you search you're going to get a fairly stable set of results .. I'm picking a random one of that set. If you've used the shuffle button in Slack's /giphy command, it's much the same.

As a napkin-math scenario, I still had Postman results open from when I was working on the app 2 days ago. I just re-requested the same search results and the same gif was the top result.

HOWEVER, I'm caching based on the search query, so there's probably not going to be a high hit rate between app installations (what are the chances people are searching for the same stuff?)

DigitallyBorn avatar Aug 19 '22 00:08 DigitallyBorn

Ok, how about I merge this and make it available for beta testers only? If you shoot me a DM on our Discord I can get you added to the beta group and try to move things forward.

matslina avatar Aug 25 '22 15:08 matslina

We're automatically closing this issue because it hasn't had any activity in 30 days. If that seems like a mistake, please feel free to re-open. Thanks!

stale[bot] avatar Sep 26 '22 01:09 stale[bot]