community icon indicating copy to clipboard operation
community copied to clipboard

Adds new general bike share feed specification applet

Open snorremd opened this issue 1 year ago • 4 comments

The PR implements a new bikeshare applet that supports bikeshare companies using the general bikeshare feed specification. The applet shows the availability of bikes and parking respectively for a user selected provider and stations.

The applet allows users to select one of the providers listed in NABSA's systems list. It uses schema.Generated to facilitate selection of the two stations to show statuses for. Caching is used for all requests to minimise load on GBFS APIs and a user agent links back to the app.

Any feedback is welcome!

I should probably improve the error handling as it now uses the fail() function which is not best practice.

bikeshare

snorremd avatar Jul 24 '22 20:07 snorremd

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

tidbyt-bot avatar Jul 24 '22 20:07 tidbyt-bot

I have read the CLA Document and I hereby sign the CLA

snorremd avatar Jul 24 '22 20:07 snorremd

I had to rewrite the commit history as I had used my work email instead of my personal email in the commits. Seem to have rewritten one too many commit. Will fix the history if necessary and add some better error handling soon.

Edit: I've squashed the commits into one and fixed so history is correct.

snorremd avatar Jul 24 '22 21:07 snorremd

I was starting to build this! Glad to have a PR started and excited to use this!

joshbeckman avatar Jul 25 '22 15:07 joshbeckman

This is really sweet!

matslina avatar Aug 18 '22 20:08 matslina

This is really sweet!

Thank you! I really appreciate you taking the time to review and merge. 😄 Loving my Tidbyt so far.

snorremd avatar Aug 19 '22 06:08 snorremd