community icon indicating copy to clipboard operation
community copied to clipboard

Initial version of app to display dinner specials at Selland's restaurants

Open matthewkent opened this issue 11 months ago • 1 comments

Description

Show weekly dinner for two specials at Selland's restaurants in the Sacramento area. sellands_specials

Copilot

copilot:all

matthewkent avatar Feb 28 '24 20:02 matthewkent

⚠️ The automated review process is experimental and likely has bugs. Please bear with us as we iron out the kinks and enable you to ship changes at high velocity 🚀

Next Steps

Hello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:

  • [ ] Sign the CLA if you haven't already
  • [ ] Ensure your build is green! Any problem will display a proposed solution to try out
  • [ ] Get a review, either by Tidbyt Bot or by a Tidbyt engineer

Manual Review Required

Hang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:

Test Details
App Dir All files are in a single app directory
🟡 Modules Usage of html.star requires review
Original Author The original author matches the PR author

Previews

apps/sellandsspecials/sellands_specials.star:

tidbyt[bot] avatar Feb 28 '24 20:02 tidbyt[bot]

Hey there. Just in case you didn't notice it already, the app can't be merged due to a CI failure:

apps/sellandsspecials/sellands_specials.star
  ▪️ Problem: app takes too long to render 1.2[8](https://github.com/tidbyt/community/actions/runs/8086519604/job/22096452719?pr=2311#step:5:9)[9](https://github.com/tidbyt/community/actions/runs/8086519604/job/22096452719?pr=2311#step:5:10)885896s
  ▪️ Solution: try optimizing your app using `pixlet profile apps/sellandsspecials/sellands_specials.star` to get it under 1s

matslina avatar Mar 21 '24 12:03 matslina

Thanks for flagging. I noticed this and have been trying to figure out another approach but I think I'm out of luck. The app is quite simple, just makes one GET request and then parses some HTML, but I think the web site is too slow to reliably return under 500ms.

matthewkent avatar Mar 21 '24 15:03 matthewkent