community icon indicating copy to clipboard operation
community copied to clipboard

first commit of select.live app.

Open simonhac opened this issue 11 months ago • 5 comments

Description

a pixlet app to remotely display the status of a Selectronic SP PRO inverter fetching data from select.live

select_live

Copilot

copilot:all

simonhac avatar Feb 27 '24 23:02 simonhac

⚠️ The automated review process is experimental and likely has bugs. Please bear with us as we iron out the kinks and enable you to ship changes at high velocity 🚀

Next Steps

Hello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:

  • [ ] Sign the CLA if you haven't already
  • [ ] Ensure your build is green! Any problem will display a proposed solution to try out
  • [ ] Get a review, either by Tidbyt Bot or by a Tidbyt engineer

Manual Review Required

Hang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:

Test Details
App Dir All files are in a single app directory
🟡 Modules Usage of http.star requires review
Original Author The original author matches the PR author

Previews

apps/selectlive/select_live.star:

tidbyt[bot] avatar Feb 27 '24 23:02 tidbyt[bot]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

tidbyt-bot avatar Feb 27 '24 23:02 tidbyt-bot

I have read the CLA Document and I hereby sign the CLA

simonhac avatar Feb 27 '24 23:02 simonhac

recheck

simonhac avatar Feb 27 '24 23:02 simonhac

so, is this in your hands @matslina? (my first PR to this repo!)

simonhac avatar Feb 27 '24 23:02 simonhac

Hey @simonhac. Yes, it is in my hands. Apologies for the terrible delay. We're really focused on Tidbyt Gen 2 functionality right now, and the community repo is unfortunately lagging behind a whole lot. Trying to catch up bit by bit.

If i understand this correctly, the app will (currently) pass data through your service (code included in the PR) hosted on replit? I think we can do that, but we'd need a very clear explanation in the app description that lets users know their username and password will be passing through a 3rd party service hosted by you. And it'd need to be like, very clear.

I'll try to take a look at the cookie discussion in the PR you linked sometime soon, but can't promise much because... Gen 2.

matslina avatar Mar 18 '24 16:03 matslina

thanks @matslina i'll have a go at writing that app description.

(i'm a bit of a git newbie, so will need to google around to work out how to update the PR.)

can't wait to get my hands on a Gen 2… though looks like it doesn't ship to australia :(

simonhac avatar Mar 18 '24 16:03 simonhac

Hey. Updating the PR should be simple. Head to your fork of the community repo and run:

$ git add apps/selectlive/manifest.yaml
$ git ci -m "update manifest"
$ git push

And now that I read that I remember how complicated git really is... Well, good luck! =)

matslina avatar Mar 21 '24 12:03 matslina

We're automatically closing this issue because it hasn't had any activity in 30 days. If that seems like a mistake, please feel free to re-open. Thanks!

stale[bot] avatar Apr 22 '24 02:04 stale[bot]