community icon indicating copy to clipboard operation
community copied to clipboard

New App: Dense Time Temp

Open jordan-p opened this issue 4 months ago • 3 comments

Description

Add new app that displays time, weather (temperature, wind, "feels like"), and sunrise/sunset

Copilot

copilot:all

jordan-p avatar Feb 26 '24 00:02 jordan-p

⚠️ The automated review process is experimental and likely has bugs. Please bear with us as we iron out the kinks and enable you to ship changes at high velocity 🚀

Next Steps

Hello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:

  • [ ] Sign the CLA if you haven't already
  • [ ] Ensure your build is green! Any problem will display a proposed solution to try out
  • [ ] Get a review, either by Tidbyt Bot or by a Tidbyt engineer

Manual Review Required

Hang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:

Test Details
App Dir All files are in a single app directory
🟡 Modules Usage of http.star requires review
Original Author The original author matches the PR author

Previews

apps/dense_time_temp/dense_time_temp.star:

tidbyt[bot] avatar Feb 26 '24 00:02 tidbyt[bot]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

tidbyt-bot avatar Feb 26 '24 00:02 tidbyt-bot

I have read the CLA Document and I hereby sign the CLA

jordan-p avatar Feb 26 '24 00:02 jordan-p

Hey @jordan-p. First of all, apologies for the very delayed review here. We've been heads down on Tidbyt Gen 2 for the past month, and the community PR process is lagging behind!

This looks pretty good, and I'm happy to merge. Wanted to suggest one thing though. The image assets here are pretty large, which makes the starlark file kinda giant. I checked one of them (the thunderstorm graphic), and it comes in at about 2.8K currently. Just stripping EXIF data from it reduced it to 196 bytes, which makes it all a bit more manageable. So that could be worth looking into! It's as simple as running exiftool -all= thunderstorm.png.

matslina avatar Mar 19 '24 17:03 matslina