community icon indicating copy to clipboard operation
community copied to clipboard

Fix: Melbourne Trains

Open bendiep opened this issue 1 year ago • 2 comments
trafficstars

Description

Use the correct encryption command for the encrypted keys used in the app.

before:

pixlet encrypt <manifest packageName value> "<key>"

after:

pixlet encrypt <manifest id value> "<key>"

Copilot

copilot:all

bendiep avatar Feb 13 '24 03:02 bendiep

⚠️ The automated review process is experimental and likely has bugs. Please bear with us as we iron out the kinks and enable you to ship changes at high velocity 🚀

Next Steps

Hello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:

  • [ ] Sign the CLA if you haven't already
  • [ ] Ensure your build is green! Any problem will display a proposed solution to try out
  • [ ] Get a review, either by Tidbyt Bot or by a Tidbyt engineer

Manual Review Required

Hang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:

Test Details
App Dir All files are in a single app directory
🟡 Modules Usage of http.star requires review
Original Author The original author matches the PR author

Previews

apps/melbournetrains/melbourne_trains.star:

tidbyt[bot] avatar Feb 13 '24 03:02 tidbyt[bot]

Hi @matslina

I've updated the encryption command used to encrypt the keys for this app.

The app is working perfectly locally. However in the Tidbyt app store, my app just shows a cloud icon with a cross through it. My app has fallback render logic for various error edge cases, so it should at-least display something... Can you give me some details on how I can debug such an issue?

bendiep avatar Feb 13 '24 03:02 bendiep

Looks like this PR fixed the problem? I'm at least seeing departures now, although I'm admittedly not up to speed on Melbourne local transit. Would love to go there sometime though.

matslina avatar Mar 07 '24 21:03 matslina