community icon indicating copy to clipboard operation
community copied to clipboard

Fix: Wiki Page Today

Open sch0lars opened this issue 1 year ago • 1 comments

  • Added logic to retrieve previous article if current article is not available
  • Added logic to print a failure message if no featured article can be found
  • Added default thumbnail to address missing key error
  • Added language feature
  • Added font color feature

Description

The current app was not displaying featured articles, oftentimes failing because of unhandled exceptions. I have added fixes for these issues, including:

  • Adding a default thumbnail when the featured article does not contain one
  • Checking for the previous day's featured article when the current day's article cannot be found
  • Adding a failure message when neither of the aforementioned articles can be found

I have also added two additional features:

  1. Language options to display the featured article in different languages
  2. An option to change the font color

Copilot

copilot:all

sch0lars avatar Feb 11 '24 05:02 sch0lars

⚠️ The automated review process is experimental and likely has bugs. Please bear with us as we iron out the kinks and enable you to ship changes at high velocity 🚀

Next Steps

Hello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:

  • [ ] Sign the CLA if you haven't already
  • [ ] Ensure your build is green! Any problem will display a proposed solution to try out
  • [ ] Get a review, either by Tidbyt Bot or by a Tidbyt engineer

Manual Review Required

Hang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:

Test Details
App Dir All files are in a single app directory
🟡 Modules Usage of http.star requires review
🟡 Original Author The original author (theUnBurn) does not match the PR author (sch0lars)

Previews

apps/wikipagetoday/wiki_page_today.star:

tidbyt[bot] avatar Feb 11 '24 05:02 tidbyt[bot]

@theUnBurn Thoughts on this one?

matslina avatar Mar 07 '24 21:03 matslina

Looks good to me! Thanks for updating this, and appreciate you taking the time to do this!

theUnBurn avatar Mar 07 '24 21:03 theUnBurn