community icon indicating copy to clipboard operation
community copied to clipboard

Public repos do not need PAT to access rest API

Open kenodegard opened this issue 1 year ago • 3 comments

Description

Update GitHub Badge app to optionally use the GitHub PAT (it's only necessary if the repo is private).

Otherwise included a few minor spelling corrections.

Copilot

copilot:all

kenodegard avatar Feb 09 '24 14:02 kenodegard

⚠️ The automated review process is experimental and likely has bugs. Please bear with us as we iron out the kinks and enable you to ship changes at high velocity 🚀

Next Steps

Hello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:

  • [ ] Sign the CLA if you haven't already
  • [ ] Ensure your build is green! Any problem will display a proposed solution to try out
  • [ ] Get a review, either by Tidbyt Bot or by a Tidbyt engineer

Manual Review Required

Hang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:

Test Details
App Dir All files are in a single app directory
🟡 Modules Usage of http.star requires review
🟡 Original Author The original author (Cavallando) does not match the PR author (kenodegard)

Previews

apps/githubbadge/github_badge.star:

tidbyt[bot] avatar Feb 09 '24 14:02 tidbyt[bot]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

tidbyt-bot avatar Feb 09 '24 14:02 tidbyt-bot

I have read the CLA Document and I hereby sign the CLA

kenodegard avatar Feb 09 '24 14:02 kenodegard

@Cavallando Thoughts on this one?

matslina avatar Mar 07 '24 21:03 matslina

Very sorry for the delay @kenodegard, awesome changes, thank you very much!

@matslina looks good to me! 🚀

Cavallando avatar Mar 08 '24 00:03 Cavallando

@matslina not sure if this is the best place for feedback but I see you all are improving your contrib processes

The automated review process is experimental and likely has bugs. Please bear with us as we iron out the kinks and enable you to ship changes at high velocity 🚀

I'm sure you all have thought of this but just in case, I think it'd be helpful if the original Author was tagged either mentioned in a comment or assigned to the PR, would hate to leave other devs hanging like I did on this PR lol

Cavallando avatar Mar 08 '24 17:03 Cavallando

@Cavallando good idea!

matslina avatar Mar 08 '24 18:03 matslina