community icon indicating copy to clipboard operation
community copied to clipboard

UPDATE: Vgk next game

Open theimpossibleleap opened this issue 1 year ago • 3 comments

Description

Changed to call response.json() once per recommendation. Thank you!

Copilot

copilot:all

theimpossibleleap avatar Feb 08 '24 20:02 theimpossibleleap

⚠️ The automated review process is experimental and likely has bugs. Please bear with us as we iron out the kinks and enable you to ship changes at high velocity 🚀

Next Steps

Hello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:

  • [ ] Sign the CLA if you haven't already
  • [ ] Ensure your build is green! Any problem will display a proposed solution to try out
  • [ ] Get a review, either by Tidbyt Bot or by a Tidbyt engineer

Manual Review Required

Hang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:

Test Details
App Dir All files are in a single app directory
🟡 Modules Usage of http.star requires review
Original Author The original author matches the PR author

Previews

apps/vgknextgame/vgk_next_game.star:

tidbyt[bot] avatar Feb 08 '24 20:02 tidbyt[bot]

Added another commit that updates the base64 pixel art to be a lot cleaner! Thank you.

theimpossibleleap avatar Feb 11 '24 17:02 theimpossibleleap

Added another commit to change the time format. Hopefully these make it in! Also, when pull request is complete, will the App update on my Tidbyt automatically, or do I need to remove it and re-add it? Any help is appreciated! Thank you.

theimpossibleleap avatar Feb 12 '24 20:02 theimpossibleleap

Hey. Sorry for the delay. We've been heads down on Gen 2 stuff for the past weeks, which unfortunately results in us neglecting the community repo... =(

This PR has a conflict which is preventing me from merging it. Please rebase your branch onto the latest version of the main branch. This means updating your branch with the latest changes from the main branch and resolving any conflicts that arise, which in turn will allow us to merge it.

If that sounds like gibberish - and a lot of git magic does sound like gibberish, so don't sweat it - you can also create a completely new fork of the community repo, apply your edits there (e.g. by just copying over the latest versions of the relevant files from this fork), and then opening up a brand new PR.

Once the PR is merged, the app will update automatically without any need for you to do anything on your side. The updated app should appear on your Tidbyt(s) in a matter of minutes.

matslina avatar Mar 07 '24 21:03 matslina

Hey @matslina! No problem at all, hope y'all are settling in now. I tried to do the rebase but I'm not sure if I did it right. Please let me know. If I didn't, I'll just do the fork method. Thank you!

theimpossibleleap avatar Mar 08 '24 17:03 theimpossibleleap

Afraid the conflict is still there. A brand new fork should hopefully do the trick.

matslina avatar Mar 08 '24 17:03 matslina