community
community copied to clipboard
updated supported coins list to 20240201
Description
Only change was to update SUPPORTED_COINS to latest, as of 20240201. This simply allows coingecko price app to have most up-to-date list of coins (instead of older 2022 version).
Copilot
copilot:all
β οΈ The automated review process is experimental and likely has bugs. Please bear with us as we iron out the kinks and enable you to ship changes at high velocity π
Next Steps
Hello! Thank you so much for your change π€ π€ . There are a few things you need to do:
- [ ] Sign the CLA if you haven't already
- [ ] Ensure your build is green! Any problem will display a proposed solution to try out
- [ ] Get a review, either by Tidbyt Bot or by a Tidbyt engineer
Manual Review Required
Hang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:
| Test | Details | |
|---|---|---|
| β | App Dir | All files are in a single app directory |
| π‘ | Modules | Usage of cache.star requires review |
| π‘ | Original Author | The original author (aschober) does not match the PR author (hodgerpodger) |
Previews
apps/coingeckoprice/coingecko_price.star:
I have read the CLA Document and I hereby sign the CLA
@aschober Thoughts on this one?
Would love to get this in, as I use this app everyday. Alternatively, I may submit a different app name (after some time if no response) also to guarantee the original one stable, if thatβs preferable.
If we don't hear back from @aschober in a few days, then I'm inclined to merge.
@hodgerpodger @matslina GitHub makes viewing lots of line changes complicated. But LGTM.