Tidal icon indicating copy to clipboard operation
Tidal copied to clipboard

Parser errors for new rest symbol

Open nkleemann opened this issue 1 year ago • 1 comments

As a german keyboard layout user, thank you very much for: #1087

After experimenting with this I found patterns that trips up the parser:

  • "[--"
  • "<---"
  • "- 2" (as used in $ slow "- 2", $ slow "~ 2" is working fine)

example:

d1
    $ n "[-- 0 5]"
    # s "cpu"

Failed to Stream.streamReplace: Syntax error in sequence: "[-- 0 5]" ^
unexpected end of input expecting sequence, ",", "|" or "]" Return to previous pattern.

nkleemann avatar Jul 01 '24 13:07 nkleemann

Ah thanks for this, the patch was surprisingly simple, I guess too simple! I'll add some breaking tests to mark this out as a release blocking bug

yaxu avatar Jul 02 '24 09:07 yaxu

I wanted to look at the parser anyways :)

sss-create avatar Jan 19 '25 13:01 sss-create

I wanted to look at the parser anyways :)

Thanks @sss-create , it looks like I failed to add the test but it is still broken. I added it to a milestone for the next release 1.10 for now.

yaxu avatar Jan 19 '25 15:01 yaxu