Tidal icon indicating copy to clipboard operation
Tidal copied to clipboard

Backport changes from retired 2.0 branch

Open yaxu opened this issue 1 year ago • 9 comments
trafficstars

The old 2.0-dev branch is now retired.

Some changes should be backported to the active dev branch.

PRs to look at:

  • [ ] #1055
  • [ ] #1027
  • [x] #1006
  • [ ] #1012
  • [x] #1007 ref #1074
  • [x] #995

[cycseq](https://github.com/tidalcycles/Tidal/tree/cycseq / #1031 ) things

  • [ ] https://github.com/tidalcycles/Tidal/commit/62c2eec545ea97c1c3a971ed3e63c5271607313c
  • [ ] move base package to tidal-core, splitting out tidal-params-dirt and tidal-stream

yaxu avatar Apr 13 '24 21:04 yaxu

#1081 addresses the Sound.Tidal.Boot changes and is ready for review. I've mostly got the handshake OSC changes ported too, but I want to add a couple tests and bug fixes to address #1030.

I'm also interested in taking a look at some of the package reorganization code, but can approach that more piecemeal.

matthewkaney avatar Apr 17 '24 17:04 matthewkaney

anything I can help with? How about the Megaparsec branch in ParseBP? I'm firm with hosc too. Or something basic so I can familiarize with the code base especially Patterns, ControlPatterns and how the cycling works.

sss-create avatar Jan 08 '25 14:01 sss-create

Hi @sss-create ! As far as I remember, I didn't get far with megaparsec, and don't have a sense for the advantages of switching to it. Feel free to have a fresh look, but I'd assume that would involve starting afresh. We should probably continue discussion in a dedicated issue to it.

Otherwise from this task it looks like #1055 and #1012 still need merging into dev and are probably straightforward. I'm unsure about #1027, do you know @matthewkaney ?

yaxu avatar Jan 10 '25 12:01 yaxu

@yaxu #1027 is taken care of in #1051, which isn't merged yet. I remember it was basically done, but don't remember why I didn't wrap it up (maybe test failures or something?) I'll investigate and we should get this in before the next release!

matthewkaney avatar Jan 15 '25 17:01 matthewkaney

@matthewkaney great yes it seems it's good to merge, just with some conflicts to resolve. LMK if I can help!

yaxu avatar Jan 15 '25 23:01 yaxu

If you don't mind, I'd check the conflicts.

sss-create avatar Jan 31 '25 19:01 sss-create

@yaxu, close this? how about 62c2eec?

sss-create avatar Feb 19 '25 17:02 sss-create

@yaxu, close this? how about 62c2eec?

Heh coincidentally @matthewkaney was just looking at comparing how these functions are implemented in the different tidals..

yaxu avatar Feb 19 '25 23:02 yaxu

fastgap got bugfixed in 2.0 https://github.com/tidalcycles/Tidal/blob/2263c2e348579519cf3589965889faed7c88dffe/src/Sound/Tidal/Signal/Base.hs#L462-L482

yaxu avatar Mar 10 '25 09:03 yaxu