Tim Collins comments

Results 51 comments of


                                            Tim Collins

`terminationGracePeriodSeconds` not respected when daemon task terminates

Context for whoever picks this up: https://cloud-native.slack.com/archives/C01QW9QSSSK/p1679402429354709

fix(argo-workflows): create service account secrets

I agree with @vladlosev

docs: add example ValidatingAdmissionPolicy to block param interpolation

Personally, I'd like to see a proper documentation page on this. Stumbling across the examples probably isn't the best UX.

fix(argo-cd): support empty matches in GRPCRoute rules

> Despite the checklist item, it seems `artifacthub.io/changes` is not really used, so I didn't bother. It's used for every single PR and is a requirement.

fix(argo-cd): support empty matches in GRPCRoute rules

Very much a requirement. Very much not new. You replace the old with the new. That's how people know what has changed with your release.

chore: update leads (max 2 per project)

+1 binding

chore: clean up kubebuilder annotations in executor_swagger.md

@coderabbit full review

chore(argo-cd): Align haproxy connections default timeout with Argo CD redis client

Thanks for this, but this won't get released until it has been released upstream.

fix(argo-rollouts,argo-workflows): Replace "float64" with "int" to fix Helm 3.18 incompatibility

Can you please split this into two PRs? Different teams review different projects and the CI thinks this is just rollouts. edit: hmm maybe it doesn't. I'd prefer it split...

fix(argo-rollouts,argo-workflows): Replace "float64" with "int" to fix Helm 3.18 incompatibility

Closing in favour of #3386 and #3387. Thanks for your contribution.