qgit icon indicating copy to clipboard operation
qgit copied to clipboard

[macOS] App icon is broken on Sonoma / arm64

Open barracuda156 opened this issue 1 year ago • 6 comments

This is not how it is supposed to look, I assume?

qgit

Built with Qt5.

barracuda156 avatar Jan 02 '24 00:01 barracuda156

Thanks for your report.

More info will be needed. As we can verify, the original files in the source repo are OK: https://github.com/tibirna/qgit/blob/master/src/resources/qgit.png https://github.com/tibirna/qgit/blob/master/src/resources/qgit.svg

tibirna avatar Jan 03 '24 01:01 tibirna

@tibirna Have you got an arm64 Mac hardware? This should be reproducible, I believe, at least on Sonoma, by just installing qgit from Macports.

barracuda156 avatar Jan 03 '24 07:01 barracuda156

Hi @barracuda156 , I had a quick look since I was the last one to update the icon used for the MacOS. It seems the problem is related to the available icon sizes in the icon set file (qgit.icns).

It seems at the time I only added one size (64x64) which was made from a SVG file I created to increase the resolution as the original icon was very small and blurry on the newer high resolution screens.

I have now created an icon set with many more sizes which MacOS Sonoma is happy with. They must have changed something to use a specific image size.

Have a look into the PR #142

filiperinaldi avatar Jan 04 '24 19:01 filiperinaldi

Thanks for your report.

More info will be needed. As we can verify, the original files in the source repo are OK: https://github.com/tibirna/qgit/blob/master/src/resources/qgit.png https://github.com/tibirna/qgit/blob/master/src/resources/qgit.svg

@tibirna , the MacOS installation uses the https://github.com/tibirna/qgit/blob/master/src/resources/qgit.icns file which is a set of icons at different resolutions.

filiperinaldi avatar Jan 04 '24 19:01 filiperinaldi

@filiperinaldi Great, I will try it. Thank you!

barracuda156 avatar Jan 04 '24 19:01 barracuda156

Thank you, @filiperinaldi, for looking into this. I will merge the branch as is, even without confirmation of the fix.

tibirna avatar Jan 05 '24 23:01 tibirna