tibetiroka

Results 352 comments of tibetiroka

`on fail` and `on abort` still works. NPC triggers are kinda broken; they can fail a mission _then_ do something, which now gets ignored.

This change restores the previous NPC behaviour. This means NPCs can still fail a mission before showing a popup dialog. The issue with this is that if there are multiple...

> To me, saying this is bugged would imply that the original intention was for actions to not trigger after the mission has already failed. I don't get the impression...

The string token is a placeholder, and I need to test that it works at all.

It's a hacky workaround, but it works; the previous behaviour can now be restored by adding `"triggers for failed missions"` as the first line in the mission action. I do...

Yeah the token is just a placeholder for now

That sounds really interesting. It's beyond the scope of this PR, but it would certainly enable more functionality. An alternative could be to allow giving conditions to any `action` node....

@Zitchas Can you fix the merge conflicts? I also see some unaddressed comments above, could you look at those at some point?

In the future, it might be better to first open a discussion about such major changes first, and only once consensus is reached, open the pr. That will make it...