Tiberiu Ichim

Results 250 comments of Tiberiu Ichim

Hi @MdSahil-oss. It's really good to see your contribution! I have one feedback, maybe you can take it into consideration. I've always wished that some Volto's "heavy" components (such as...

anything that would reduce ongoing babel dependencies pain is worth taking the initial "hit"

It doesn't seem like the srcset properly responds to the images. I can see the /listing being loaded, but it's always loading the big image instead of one of the...

Thanks @datakurre! I ran the validator on the PR, on a page with a listing block and a hero block. Here's the things it has to say: ![Screenshot 2021-01-23 124120](https://user-images.githubusercontent.com/141568/105576002-8728f880-5d78-11eb-8a52-591991b43d2a.png)

Isn't the @@images/image/listing size too small? 16px, as is the default, is no bigger then a small icon. Yes, it loads fast, but it's also ugly. I suggest maybe use...

@datakurre No worries, I haven't yet plugged the new image scales into Plone, this was with the default image scales. I am trying to get a feeling of what this...

@nzambello My hope for this PR is that, in the end, it provides a comprehensive solution for responsive images. One issue I have though, and maybe I have read the...

Another idea: when definining image scales, I think it could be interesting to also define resizing parameters. Looking at [these parameters](https://sharp.pixelplumbing.com/api-resize#resize), for example (most important, fit type and positions. Right...

Assuming that initialPath is the same as that of the content.

@JeffersonBledsoe In one of my websites I did this (not sure it's enough): ``` config.settings.nonContentRoutes = [ ...config.settings.nonContentRoutes.filter((p) => p !== '/search'), ]; ``` and I've created a /search page...