Johan Tibell

Results 165 comments of Johan Tibell

Making the inner vector (i.e. when we return a `Vector (Vector a))`) `Storable` should work, we already support unboxed inner vectors. Making the outermost vector storable is a bit trickier,...

I'm on vacation. Will take a look when I get back. On Nov 25, 2014 3:10 AM, "Chris Allen" [email protected] wrote: > @tibbe https://github.com/tibbe does this sound even remotely like...

I think pipes is a too heavy dependency and I don't want to commit to one of the many competing streaming solutions out there until the community settles on something....

The main issue is that I don't want to pick one out of N competing streaming solutions. It won't be long before people want the alternatives. On top of that,...

Good catch. This is a bit odd since `decode` eventually ends up calling the parser called `csv`, defined in `Encoding.hs`: ``` haskell csv :: FromRecord a => DecodeOptions -> AL.Parser...

Great detective work. We should indeed switch to using `parse` then. I've filed a bug with attoparsec to get the docs fixed.

There could perhaps be an option for quoting on decoding, but the above isn't valid CSV due to the extra whitespace.

The change looks good from a brief look. I will have to take a deeper look and run the benchmarks later next week (I'm very busy this week, sorry!)

I took a deeper look and things look fine except for the small comments above. Could you please post the criterion benchmarks for before and after your change (you can...