edk2 icon indicating copy to clipboard operation
edk2 copied to clipboard

MdeModulePkg/Core: CoreValidateHandle optimization

Open XiaoqiangZhang1 opened this issue 1 year ago • 10 comments

Description

<Include a description of the change and why this change was made.>

<For each item, place an "x" in between [ and ] if true. Example: [x] (you can also check items in GitHub UI)>

<Create the PR as a Draft PR if it is only created to run CI checks.>

<Delete lines in <> tags before creating the PR.>

  • [ ] Breaking change?
    • Breaking change - Does this PR cause a break in build or boot behavior?
    • Examples: Does it add a new library class or move a module to a different repo.
  • [ ] Impacts security?
    • Security - Does this PR have a direct security impact?
    • Examples: Crypto algorithm change or buffer overflow fix.
  • [ ] Includes tests?
    • Tests - Does this PR include any explicit test code?
    • Examples: Unit tests or integration tests.

How This Was Tested

Tested on latest server 8S system

Integration Instructions

N/A

XiaoqiangZhang1 avatar Aug 07 '24 08:08 XiaoqiangZhang1

Please separate the change for MdePkg as the single commit.

This is good performance enhancement. Do you plan to catch this change in the comming edk2 stable tag 202408?

lgao4 avatar Aug 08 '24 01:08 lgao4

N/A

Thanks Liming,

  1. Separated the change for MdePkg: https://github.com/tianocore/edk2/pull/6063
  2. Yes, if no objection to this patch, please help to merge the MdePkg change first and then I can rebase the MdeModulePkg change to merge.

XiaoqiangZhang1 avatar Aug 08 '24 03:08 XiaoqiangZhang1

N/A

Thanks Liming,

  1. Separated the change for MdePkg: MdePkg: CoreValidateHandle Optimization Part1 #6063
  2. Yes, if no objection to this patch, please help to merge the MdePkg change first and then I can rebase the MdeModulePkg change to merge.

I mean to add two commits in these Pull Reqest. One is the change in MdePkg, another is in MdeModulePkg. I don't request two PRs.

lgao4 avatar Aug 10 '24 01:08 lgao4

N/A

Thanks Liming,

  1. Separated the change for MdePkg: MdePkg: CoreValidateHandle Optimization Part1 #6063
  2. Yes, if no objection to this patch, please help to merge the MdePkg change first and then I can rebase the MdeModulePkg change to merge.

I mean to add two commits in these Pull Reqest. One is the change in MdePkg, another is in MdeModulePkg. I don't request two PRs.

Thank you, done!

XiaoqiangZhang1 avatar Aug 12 '24 04:08 XiaoqiangZhang1

N/A

Thanks Liming,

  1. Separated the change for MdePkg: MdePkg: CoreValidateHandle Optimization Part1 #6063
  2. Yes, if no objection to this patch, please help to merge the MdePkg change first and then I can rebase the MdeModulePkg change to merge.

I mean to add two commits in these Pull Reqest. One is the change in MdePkg, another is in MdeModulePkg. I don't request two PRs.

Thank you, done!

Please remove part1, part2 in the commit message.

lgao4 avatar Aug 13 '24 03:08 lgao4

@mdkinney, this change requests to catch the stable tag 202408. Have you any comments for it?

lgao4 avatar Aug 13 '24 05:08 lgao4

@mdkinney, this change requests to catch the stable tag 202408. Have you any comments for it?

This is an optimization and not a bug fix. What is the justification?

mdkinney avatar Aug 13 '24 15:08 mdkinney

N/A

Thanks Liming,

  1. Separated the change for MdePkg: MdePkg: CoreValidateHandle Optimization Part1 #6063
  2. Yes, if no objection to this patch, please help to merge the MdePkg change first and then I can rebase the MdeModulePkg change to merge.

I mean to add two commits in these Pull Reqest. One is the change in MdePkg, another is in MdeModulePkg. I don't request two PRs.

Thank you, done!

Please remove part1, part2 in the commit message.

Done, thank you!

XiaoqiangZhang1 avatar Aug 14 '24 09:08 XiaoqiangZhang1

@mdkinney, this change requests to catch the stable tag 202408. Have you any comments for it?

This is an optimization and not a bug fix. What is the justification?

@XiaoqiangZhang1 , please provide your detail reason. Does this change is critical for your project?

lgao4 avatar Aug 15 '24 01:08 lgao4

@mdkinney, this change requests to catch the stable tag 202408. Have you any comments for it?

This is an optimization and not a bug fix. What is the justification?

@XiaoqiangZhang1 , please provide your detail reason. Does this change is critical for your project?

Thanks Liming and Michael , after confirmation, it is okay to not catch the stable tag 202408. The change is mainly for 8S server. You can decide the timeline.

XiaoqiangZhang1 avatar Aug 16 '24 06:08 XiaoqiangZhang1

@Mergify rebase

mdkinney avatar Aug 29 '24 16:08 mdkinney

rebase

✅ Branch has been successfully rebased

mergify[bot] avatar Aug 29 '24 16:08 mergify[bot]