edk2
edk2 copied to clipboard
DynamicTablesPkg : Add RISC-V support
Description
This series adds support for RISC-V in DynamicTablesPkg. This helps in creating ACPI tables using device tree.
- [ ] Breaking change?
- Breaking change - Does this PR cause a break in build or boot behavior?
- Examples: Does it add a new library class or move a module to a different repo.
- [ ] Impacts security?
- Security - Does this PR have a direct security impact?
- Examples: Crypto algorithm change or buffer overflow fix.
- [ ] Includes tests?
- Tests - Does this PR include any explicit test code?
- Examples: Unit tests or integration tests.
How This Was Tested
RiscVVirtQemu platform is updated to use DynamicTablesPkg based on the build time option. With DynamicTablesPkg enabled, EDK2 for RiscVVirtQemu ignores the ACPI tables passed by qemu and creates new ACPI tables using the information from the DT passed from M-mode firmware (opensbi). Linux with ACPI support is booted with different interrupt controllers and with different number of cpus and verified things are created as expected.
Integration Instructions
PR can not be merged due to conflict. Please rebase and resubmit
So the poinf of adding RiscVVirtQemu support is having some easy way to test the DynamicTablesPkg code?
I'd suggest to change the last patch, add a comment explaining this, make clear the option is off by default, and explain how to turn this on if you want work on DynamicTablesPkg.
So the poinf of adding RiscVVirtQemu support is having some easy way to test the DynamicTablesPkg code?
Correct.
I'd suggest to change the last patch, add a comment explaining this, make clear the option is off by default, and explain how to turn this on if you want work on DynamicTablesPkg.
Sure. Thanks!
Hi Sunil, Thanks for the patchset, I added some comments
Great feedback!. Many thanks Pierre for your precious time to review. Let me address your comments.
PR can not be merged due to conflict. Please rebase and resubmit
This PR has been automatically marked as stale because it has not had activity in 60 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions.
PR can not be merged due to conflict. Please rebase and resubmit
Hi @vlsunil, just checking if you had any news for this PR, Regards, Pierre
Hi @vlsunil, just checking if you had any news for this PR, Regards, Pierre
Sorry @pierregondois . Got busy with some other stuff. I am working on your great feedback. Some need bit major changes. I am hoping to update in next couple of weeks.
This PR has been automatically marked as stale because it has not had activity in 60 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions.
PR can not be merged due to conflict. Please rebase and resubmit
@pierregondois : Since ACPI 6.6 is closer to get released, I think it is better to wait for it instead of adding some temporary definitions. So, let me close this for now and open new one addressing these comments after ACPI 6.6 gets released. Thank you very much for your help!