edk2 icon indicating copy to clipboard operation
edk2 copied to clipboard

ShellPkg: Add support to parse SPMI table in acpiview

Open shkrc opened this issue 1 year ago • 10 comments

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4818

Added support for acpiview shell utility to parse and print SPMI table

Cc: Abdul Lateef Attar [email protected] Cc: Abner Chang [email protected] Cc: Paul Grimes [email protected] Cc: Zhichao Gao [email protected] Signed-off-by: Shankar C [email protected]

Description

<Include a description of the change and why this change was made.>

<For each item, place an "x" in between [ and ] if true. Example: [x] (you can also check items in GitHub UI)>

<Create the PR as a Draft PR if it is only created to run CI checks.>

<Delete lines in <> tags before creating the PR.>

  • [ ] Breaking change?
    • Breaking change - Does this PR cause a break in build or boot behavior?
    • Examples: Does it add a new library class or move a module to a different repo.
  • [ ] Impacts security?
    • Security - Does this PR have a direct security impact?
    • Examples: Crypto algorithm change or buffer overflow fix.
  • [ ] Includes tests?
    • Tests - Does this PR include any explicit test code?
    • Examples: Unit tests or integration tests.

How This Was Tested

<Describe the test(s) that were run to verify the changes.>

Integration Instructions

<Describe how these changes should be integrated. Use N/A if nothing is required.>

shkrc avatar Jul 26 '24 04:07 shkrc

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4818

Added support for acpiview shell utility to parse and print SPMI table

Cc: Abdul Lateef Attar [email protected] Cc: Abner Chang [email protected] Cc: Paul Grimes [email protected]

Shankar, you need to add Signed-off-by: your name . Also need to Cc maintainers. Cc: Zhichao Gao [email protected]

abdattar avatar Jul 29 '24 08:07 abdattar

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4818 Added support for acpiview shell utility to parse and print SPMI table Cc: Abdul Lateef Attar [email protected] Cc: Abner Chang [email protected] Cc: Paul Grimes [email protected]

Shankar, you need to add Signed-off-by: your name . Also need to Cc maintainers. Cc: Zhichao Gao [email protected]

hi, i added in the commit but it did not reflect in the description. ill just edit the description

shkrc avatar Jul 29 '24 09:07 shkrc

Could you attach the dump result for SPMI table?

lgao4 avatar Jul 30 '24 05:07 lgao4

@shkrc can you paste the acpiview -S SPMI output ?

abdattar avatar Aug 02 '24 03:08 abdattar

spmi.log I have attached the log here

shkrc avatar Aug 02 '24 10:08 shkrc

Hi @lgao4 can you help review this patch?

shkrc avatar Aug 13 '24 14:08 shkrc

Hi @ZhichaoGao could you please merge the changes.

abdattar avatar Sep 01 '24 04:09 abdattar

could you please push the code changes?

abdattar avatar Sep 17 '24 05:09 abdattar

PR can not be merged due to conflict. Please rebase and resubmit

mergify[bot] avatar Sep 17 '24 05:09 mergify[bot]

Hi @lgao4 @ZhichaoGao can you help review this patch?

shkrc avatar Sep 24 '24 11:09 shkrc

This PR has been automatically marked as stale because it has not had activity in 60 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions.

github-actions[bot] avatar Nov 24 '24 23:11 github-actions[bot]

This pull request has been automatically been closed because it did not have any activity in 60 days and no follow up within 7 days after being marked stale. Thank you for your contributions.

github-actions[bot] avatar Dec 01 '24 23:12 github-actions[bot]