edk2 icon indicating copy to clipboard operation
edk2 copied to clipboard

BaseTools\Plugin\HostBasedUnitTestRunner: Reduce the number of unit t…

Open GeorgeLiao012 opened this issue 1 year ago • 6 comments

…est executions

REF : https://bugzilla.tianocore.org/show_bug.cgi?id=4801

Because of currently HostBasedUnitTestRunner.py triggered unit test twice, first for run host test, second for generate code coverage. Remove first time host test for saving time.

Description

<Include a description of the change and why this change was made.>

<For each item, place an "x" in between [ and ] if true. Example: [x] (you can also check items in GitHub UI)>

<Create the PR as a Draft PR if it is only created to run CI checks.>

<Delete lines in <> tags before creating the PR.>

  • [ ] Breaking change?
    • Breaking change - Will this cause a break in build or boot behavior?
    • Examples: Add a new library class or move a module to a different repo.
  • [ ] Impacts security?
    • Security - Does the change have a direct security impact?
    • Examples: Crypto algorithm change or buffer overflow fix.
  • [ ] Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests or integration tests.

How This Was Tested

<Describe the test(s) that were run to verify the changes.>

Integration Instructions

<Describe how these changes should be integrated. Use N/A if nothing is required.>

GeorgeLiao012 avatar Jul 03 '24 10:07 GeorgeLiao012

The change is good. But, need to resolve CI failure first.

lgao4 avatar Jul 08 '24 02:07 lgao4

The change is good. But, need to resolve CI failure first. Got it. Try to initial an GCC environment to check it first. I think my code changes should not impact .gcda generation, but may need to check it.

GeorgeLiao012 avatar Jul 09 '24 08:07 GeorgeLiao012

WARNING: Cannot add some reviewers: A user specified as a reviewer for this PR is not a collaborator of the repository. Please add them as a collaborator to the repository so they can be requested in the future.

Non-collaborators requested:

  • @javagedes

Attn Admins:

  • @jljusten
  • @lgao4
  • @mdkinney
  • @vincent-j-zimmer
  • @jkmathews
  • @miki-intel-work

Admin Instructions:

  • Add the non-collaborators as collaborators to the appropriate team(s) listed in teams
  • If they are no longer needed as reviewers, remove them from Maintainers.txt

PR can not be merged due to conflict. Please rebase and resubmit

mergify[bot] avatar Aug 13 '24 13:08 mergify[bot]

WARNING: Cannot add some reviewers: A user specified as a reviewer for this PR is not a collaborator of the repository. Please add them as a collaborator to the repository so they can be requested in the future.

Non-collaborators requested:

  • @javagedes

Attn Admins:

  • @jljusten
  • @lgao4
  • @mdkinney
  • @vincent-j-zimmer
  • @jkmathews
  • @miki-intel-work

Admin Instructions:

  • Add the non-collaborators as collaborators to the appropriate team(s) listed in teams
  • If they are no longer needed as reviewers, remove them from Maintainers.txt

This PR has been automatically marked as stale because it has not had activity in 60 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions.

github-actions[bot] avatar Oct 18 '24 23:10 github-actions[bot]

This pull request has been automatically been closed because it did not have any activity in 60 days and no follow up within 7 days after being marked stale. Thank you for your contributions.

github-actions[bot] avatar Oct 26 '24 23:10 github-actions[bot]