edk2 icon indicating copy to clipboard operation
edk2 copied to clipboard

StandaloneMM fixes for x86

Open PatrickRudolph opened this issue 1 year ago • 4 comments

Description

StandaloneMM fixes for x86.

How This Was Tested

Build using edk2-platform.

Integration Instructions

N/A

PatrickRudolph avatar Jun 24 '24 12:06 PatrickRudolph

The change in BaseTools is good to me.

lgao4 avatar Jul 22 '24 10:07 lgao4

SEC and PEI images can execute in place because there are tight restrictions on the use of global variables and statically allocated buffers. This means that such PE images cannot have BSS sections, and so the compile time footprint of the image is identical to the runtime footprint.

I always have doubts about XIP. Thanks for clarifying the restriction of no BSS section:)

Is it guaranteed that this is also the case for standalone MM drivers? Where is this covered in the PI specification? Note that XIP generally means execute from flash, which is read-only. XIP from writable memory (or cache-as-RAM) is a different use case altogether, so before accepting these changes, I need to be convinced that the PI spec and the base tools cover this use case as well.

I do not think PI spec mandates anything on XIP. I am curious what mechanism has been there to check the non-existence of the BSS section for SEC and PEI.

niruiyu avatar Jul 31 '24 09:07 niruiyu

This PR has been automatically marked as stale because it has not had activity in 60 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions.

github-actions[bot] avatar Sep 29 '24 23:09 github-actions[bot]

PR can not be merged due to conflict. Please rebase and resubmit

mergify[bot] avatar Sep 29 '24 23:09 mergify[bot]

This PR has been automatically marked as stale because it has not had activity in 60 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions.

github-actions[bot] avatar Nov 29 '24 23:11 github-actions[bot]

PR can not be merged due to conflict. Please rebase and resubmit

mergify[bot] avatar Nov 29 '24 23:11 mergify[bot]